Eskil

Check-in [9c39a2ca72]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Better layout for file selection in commit.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 9c39a2ca725cf8add826a8bd930191eea136c850d0da9895ad4571c2357df32c
User & Date: peter 2019-02-04 23:39:15
Context
2019-02-04
23:51
Protect against weird behaviour check-in: 9faa880176 user: peter tags: trunk
23:39
Better layout for file selection in commit. check-in: 9c39a2ca72 user: peter tags: trunk
23:09
Reworked extraction of files from patch, to make it work in all supported systems. check-in: 20868060ad user: peter tags: trunk
Changes
Hide Diffs Unified Diffs Ignore Whitespace Patch

Changes to src/rev.tcl.

1818
1819
1820
1821
1822
1823
1824


1825

1826
1827
1828
1829













1830
1831




1832
1833

1834
1835
1836
1837
1838
1839
1840
    grid $w.ok $w.ca -padx 3 -pady 3
    grid columnconfigure $w $w.t -weight 1 -uniform a
    grid rowconfigure    $w $w.t -weight 1

    if {[llength $postcmd] > 1} {
        # TODO: Scrolled frame
        ttk::frame $w.f -padding 1


        set t 0

        foreach fileName $postcmd {
            set ::eskil($top,commit,fileselect$t) 1
            ttk::checkbutton $w.f.cb$t -text $fileName \
                    -variable ::eskil($top,commit,fileselect$t)













            grid $w.f.cb$t -sticky "w" -padx 1 -pady 1
            incr t




        }
        grid $w.f -sticky news -padx 3 -pady 3

    }

    tkwait visibility $w
    focus -force $w.t
    tkwait window $w.dummy

    if {!$::eskil($top,logdialogok)} {







>
>

>




>
>
>
>
>
>
>
>
>
>
>
>
>
|

>
>
>
>
|
<
>







1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852

1853
1854
1855
1856
1857
1858
1859
1860
    grid $w.ok $w.ca -padx 3 -pady 3
    grid columnconfigure $w $w.t -weight 1 -uniform a
    grid rowconfigure    $w $w.t -weight 1

    if {[llength $postcmd] > 1} {
        # TODO: Scrolled frame
        ttk::frame $w.f -padding 1
        grid $w.f - -sticky news -padx 3 -pady 3

        set t 0
        set maxW 0
        foreach fileName $postcmd {
            set ::eskil($top,commit,fileselect$t) 1
            ttk::checkbutton $w.f.cb$t -text $fileName \
                    -variable ::eskil($top,commit,fileselect$t)
            set rw [winfo reqwidth $w.f.cb$t]
            set maxW [expr {max($maxW, $rw)}]
            incr t
        }
        # Figure out how many columns
        set rw [winfo reqwidth $w.t]
        set cols [expr {max($rw / $maxW, 2)}]
        set rows [expr {($t + $cols - 1) / $cols}]

        set t 0
        set row 0
        set col 0
        foreach fileName $postcmd {
            grid $w.f.cb$t -row $row -column $col -sticky "w" -padx 1 -pady 1
            incr t
            incr row
            if {$row >= $rows} {
                incr col
                set row 0
            }

        }
    }

    tkwait visibility $w
    focus -force $w.t
    tkwait window $w.dummy

    if {!$::eskil($top,logdialogok)} {